Stats: Implement rules stats#985
Merged
Merged
Conversation
Increase every shown rule uses count when command called.
jb3
approved these changes
Jun 5, 2020
Member
|
@ks129 PR looks good, but can you edit the body to be a bit more descriptive? |
Contributor
Author
|
@J03B Is now description better? |
Member
|
I've made a couple of adjustments, but yeah, that's better. PR body clarity is quite important for searching down the line & understanding full reasoning behind a change. |
kwzrd
added
p: 2 - normal
kwzrd
approved these changes
Jun 6, 2020
Contributor
kwzrd
left a comment
kwzrd
left a comment
There was a problem hiding this comment.
Looks good, happy to approve.
Contributor
|
I agree with joe, by the way: the more relevant information you put into the PR description, the easier it'll be for us to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved in #meta following this conversation
Adds a new statistic measuring the number of times a rule is fetched using the
!rules|site rules <rules...>command.